Skip to content

fix(Order/Notation): unify at correct transparency in sup/inf delaborators#41619

Open
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-delab-supinf-transparency
Open

fix(Order/Notation): unify at correct transparency in sup/inf delaborators#41619
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-delab-supinf-transparency

Conversation

@JovanGerb

Copy link
Copy Markdown
Contributor

This PR fixes the sup/inf delaborators to use the correct transparency when unifying instances.

I discovered this problem when using #click_suggestions. It has the funny property of delaborating at the reducible transparency level instead of default (which usually doesn't affect delaboration, but in this case does)

Note: we may delay this PR until the next Lean version, since it splits this transparency level. The one we will then need is the implicit transparency.


Open in Gitpod

@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown

PR summary e36b981cbe

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit e36b981).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit e36b981cbe
Reference commit 4efb186f10

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-order Order theory label Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant