fix(Order/Notation): unify at correct transparency in sup/inf delaborators#41619
Open
JovanGerb wants to merge 1 commit into
Open
fix(Order/Notation): unify at correct transparency in sup/inf delaborators#41619JovanGerb wants to merge 1 commit into
JovanGerb wants to merge 1 commit into
Conversation
PR summary e36b981cbeImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
sup/infdelaborators to use the correct transparency when unifying instances.I discovered this problem when using
#click_suggestions. It has the funny property of delaborating at the reducible transparency level instead of default (which usually doesn't affect delaboration, but in this case does)Note: we may delay this PR until the next Lean version, since it splits this transparency level. The one we will then need is the implicit transparency.